dev/core#561 Add in deprecation notice on addDateRange funtion

[seamuslee001]

Overview

Following the various work on https://lab.civicrm.org/dev/core/issues/561 this now adds in a deprecation warning on what is now considered a deprecated function which uses jcalander to render the date fields

Before

Function not deprecated

After

Function declared as deprecated

ping @eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[yashodha]

@seamuslee001 It looks like it is still being used here

https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Form/Date.php#L176

[seamuslee001]

@yashodha yes am aware of that, I was wanting to try and put it as low down the stack as possible so that if anyone was using the addDateRangeToForm or buildDateRange or just did a direct $form->addDateRange it was picked up

doing a grep on those 2 function names you will see they aren't referenced at all in the code base anymore either, however it is probable that Extensions will be using them. So I guess the options are

1. put in the deprecation notice in all the legacy functions 2) have it at the very bottom of the stack 3) just in the wrapper functions. @eileenmcnaughton any thoughts?

seamus@civicrmdevphp7:~/buildkit/build/47-test/web/sites/all/modules/civicrm$ grep -ir 'buildDateRange' *
CRM/Core/Form/Date.php:  public static function buildDateRange(
CRM/Member/BAO/Query.php:    if ($query->buildDateRangeQuery($values)) {
CRM/Case/BAO/Query.php:    if ($query->buildDateRangeQuery($values)) {
CRM/Contact/BAO/Query.php:    // @todo also handle _low, _high generically here with if ($query->buildDateRangeQuery($values)) {return}
CRM/Contact/BAO/Query.php:  public function buildDateRangeQuery($values) {
CRM/Pledge/BAO/Query.php:    if ($query->buildDateRangeQuery($values)) {
seamus@civicrmdevphp7:~/buildkit/build/47-test/web/sites/all/modules/civicrm$ grep -ir 'addDateRangeToForm' *
CRM/Core/Form/Date.php:    CRM_Core_Form_Date::addDateRangeToForm(
CRM/Core/Form/Date.php:  public static function addDateRangeToForm(

[eileenmcnaughton]

OK - I guess we need to surface to devs that if they are using this they need to stop as it won't always work. I'm pretty sure extended reports will need a patch for this