log error message instead of throwing exception #16880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
reviewed
Mar 23, 2020
Civi/Token/TokenCompatSubscriber.php
Outdated
| @@ -63,7 +63,8 @@ public function onEvaluate(TokenValueEvent $e) { | |||
| $contact = reset($contact); | |||
| if (!$contact || is_a($contact, 'CRM_Core_Error')) { | |||
| // FIXME: Need to differentiate errors which kill the batch vs the individual row. | |||
| throw new TokenException("Failed to generate token data. Invalid contact ID: " . $row->context['contactId']); | |||
| CRM_Core_Error::debug_log_message("Failed to generate token data. Invalid contact ID: " . $row->context['contactId']); | |||
There was a problem hiding this comment.
@yashodha Please use \Civi::log()->debug()
|
@bhahumanists @aydun @eileenmcnaughton You may all have views on this - as this may be contributing to a bad token killing the scheduled reminder job. As we're running a foreach loop throwing an exception will kill the entire batch instead of just the one that failed. |
|
+1 logging rather aborting seems more reasonable here. |
|
Thanks @yashodha |
|
I can see the rationale here - but is there also a risk that people could silently be getting weird emails with missing text due to tokens being skipped? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
log error message instead of throwing exception
Before
can cause the scheduled job to fail if the token data for a contact is not generated properly.
After
log the error and carry on for the rest of the contacts.