Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger fatalErrorHandler for PEAR errors and for logs with severity ERROR or higher #17277

Merged
merged 1 commit into from
May 15, 2020

Conversation

mattwire
Copy link
Contributor

Overview

@mlutfy This allows extensions like reporterror to report most errors in CiviCRM. It includes your patch from https://lab.civicrm.org/extensions/reporterror/-/blob/master/README.md

Before

Only CRM_Core_Error::fatal() errors handled by fatalErrorHandler.

After

CRM_Core_Error::fatal(), PEAR error and \Civi::log()->error (and higher) triggers fatalErrorHandler.

Technical Details

Comments

If you don't have an extension installed which implements $config->fatalErrorHandler this PR has no effect. If you do have an extension installed then it can react to all(?) errors triggered by CiviCRM.

@civibot
Copy link

civibot bot commented May 10, 2020

(Standard links)

@civibot civibot bot added the master label May 10, 2020
@seamuslee001
Copy link
Contributor

Change looks fine to me and shouldn't impact anything and tests have passed merging

@seamuslee001 seamuslee001 merged commit a4504bb into civicrm:master May 15, 2020
@MegaphoneJon
Copy link
Contributor

This PR causes CiviMail to crash in its most common configuration on any unknown email address; see https://lab.civicrm.org/dev/mail/-/issues/72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants