[REF] remove unnecessary variable variables

[eileenmcnaughton]

Overview

For a brief but terrifying spell this arvo I delved into this function to try to understand
the purpose of 'preserveDBName'. Obviously I ran screaming from the room but I thought I could disarm these
few lines to slighly file down the fangs of the beast.

Code is heavily covered by tests

Before

$firstName = CRM_Utils_Array::value('first_name', $params, '');

...

$$fld = trim($$fld);

After

$firstName = trim($params['first_name'] ?? '');

Technical Details

Obviously this scope could creep in many directions but I'm aiming to keep trauma levels low

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Wow.

So line 116 - before the patch it might get trimmed by the removed lines lower down at 167. After the patch it wouldn't get trimmed.

Yeah.

[eileenmcnaughton]

Yeah - I think we can assume trimming has occurred already on the stuff already on the DB. For more fear-filled thrils look at deceased_date handling at the end of the function

[demeritcowboy]

$date = $date . $separator . '1902';

I don't see a suitable emoji to describe this experience.

[demeritcowboy]

Assuming $individual->$dbName is already trimmed in the db, then the only other place is line 119 and that's already handled near the top if it was in $params. Did light r-run. 👍

[seamuslee001]

changes look fine to me merging