Remove unused parameter ids['billing'] #18021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer used in later functions and a quick grep of the code finds only one deprecated function still refers to ids-billing after this
|
(Standard links)
|
eileenmcnaughton
commented
Aug 1, 2020
| @@ -216,7 +215,6 @@ public function getInput(&$input, &$ids) { | |||
| $input['response_reason_text'] = $this->retrieve('x_response_reason_text', 'String', FALSE); | |||
| $input['subscription_paynum'] = $this->retrieve('x_subscription_paynum', 'Integer', FALSE, 0); | |||
| $input['trxn_id'] = $this->retrieve('x_trans_id', 'String', FALSE); | |||
| $input['trxn_id'] = $this->retrieve('x_trans_id', 'String', FALSE); | |||
There was a problem hiding this comment.
look at the line above
|
Test fails unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
$ids['billing'] calculated, but unused
Before
After
Technical Details
This has been around a long time but most places in the code just call
CRM_Core_BAO_LocationType::getBilling();as required now so it does nothingGrepping for $ids['billing'] finds only one deprecated function
Comments