dev/core#1905 rework #17942 with simpler ts strings #18064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This reworks the template markup for the buttons added in #17942 to get all the markup out of the string to translate with
{ts}
.I also set the
title
for the whole buttons, not just the icons.Before
Translator has to translate something like
You have to hover over the wrench to see "Configure Contribution Page".
After
Translator has to translate "Configure Contribution Page" and "Configure".
You see "Configure Contribution Page" when hovering anywhere over the button.
Technical Details
I used the
{crmButton}
and{icon}
Smarty helpers to cut down on a lot of boilerplate.