Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1905 rework #17942 with simpler ts strings #18064

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Aug 4, 2020

Overview

This reworks the template markup for the buttons added in #17942 to get all the markup out of the string to translate with {ts}.

I also set the title for the whole buttons, not just the icons.

Before

Translator has to translate something like

<a class="button " target="_blank" href=%1><i aria-hidden="true" title="Configure Contribution Page" class="crm-i fa-wrench"></i> Configure</a>

You have to hover over the wrench to see "Configure Contribution Page".

After

Translator has to translate "Configure Contribution Page" and "Configure".

You see "Configure Contribution Page" when hovering anywhere over the button.

Technical Details

I used the {crmButton} and {icon} Smarty helpers to cut down on a lot of boilerplate.

@civibot
Copy link

civibot bot commented Aug 4, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Thanks @agh1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants