Move LineItem acl handling from v3 api to financialacls core extension #18293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it available for the v4 api
|
(Standard links)
|
eileenmcnaughton
changed the title
|
Yeh I think this seems fine, the NOT IN was throwing me a bit but I think this should have enough tests now but very odd still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Financial acl handling is in core but within core we are starting to restructure into a core-extension
This PR moves over the portion that relates to LineItem.get
Before
Acl directly in v3 api
After
Acl applied using best-practice hook, also available for v4 api
Technical Details
The code is a bit simpler as we didn't need to integrate it with a possibly existing key as the acl is constructed separately
Comments
@seamuslee001