/dev/core#2152: Merge contacts keep case roles

[jaapjansma]

Overview

When you merge contacts and and the old and new contact had both a role on two different cases with the same client. One of the roles gets deleted.

Before

Case roles might get deleted upon merging of contacts (if they have the same client)

After

Case roles are kept upon merging of contacts

Comments

See https://lab.civicrm.org/dev/core/-/issues/2152 for a more detailed explanation.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

• General standards
  • [r-explain] PASS
    • I'm not sure when it stopped working but I know for a fact this used to work properly some time in the past. I don't know how recent.
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
• Developer standards
  • [r-tech] PASS
    • It looks right. And I think the circular one is right too but it makes my head spin: E.g. Alice1 is the spouse for client Bob (case1) and Bob is the spouse for client Alice1 (case2) and Alice2 is the spouse for client Bob (case3) and Bob is the spouse for client Alice2 (case4). Now merge Alice1 and Alice2. That's kind of a messed up setup to begin with, but the end result looks ok when I try it.
  • [r-code] PASS
  • [r-maint] Iffy (grin)
  • [r-test] PASS