dev/core#2516 Invalidate only smart groups

[scardinius]

described here https://lab.civicrm.org/dev/core/-/issues/2516, abstract:

Method CRM_Contact_BAO_GroupContactCache::invalidateGroupContactCache() is described as touching smart groups but there is no condition for smart groups.

Current behaviour produced too much traffic on database (deadlocks).

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I think this is OK as long as we also check for when children is null - since we also cache parent groups

[mattwire]

@scardinius Please see comment from @eileenmcnaughton - needs a change to check children

[scardinius]

@eileenmcnaughton do you mean?

UPDATE civicrm_group
SET cache_date = NULL
WHERE id = %1 AND (saved_search_id IS NOT NULL OR children IS NOT NULL)

[eileenmcnaughton]

@scardinius yep that looks right

[mattwire]

@scardinius I have patched a live site where they often have problems with deadlocks. I will merge in one weeks time if it is ok there and no one else beats me to the merge :-)