Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract out getReceiveDate #20007

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Extract out getReceiveDate #20007

merged 1 commit into from
Apr 9, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 8, 2021 •
edited
Loading

Overview

Extract out getReceiveDate

Before

$paymentParams pased to processContribution passed to legacyContributionRecurCreate only to access receive_date

After

Function used to get receive date

Technical Details

Comments

@colemanw this is pretty small / straight forward

@civibot
Copy link

civibot bot commented Apr 8, 2021

(Standard links)

@civibot civibot bot added the master label Apr 8, 2021
@monishdeb
Copy link
Member

r-run passed. Reviewed patch, looks good.

@monishdeb monishdeb merged commit e053d1e into civicrm:master Apr 9, 2021
@eileenmcnaughton eileenmcnaughton deleted the mem_rec branch April 9, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @monishdeb