Search Kit links improvements #20134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves link construction to propery replace tokens in explicit joins and implicit joins.
When adding links to a column, it will now only show relevant links to the entity in the column. When adding a column of links/buttons, it will make all links available as before, but by default will only show the ones relevant to the main entity.
|
(Standard links)
|
|
test this please |
|
Thank you, now we can link the Contact reference custom fields. |
|
@kurund does that mean you've tested it? |
|
His comment on GitLab indicated that he did test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes some problems with creating links in Search Kit and improves the UX around editing links.
Before
Not possible to link to some entities, e.g. custom contact reference fields.
After
Links available for all implicit/explicit joins + custom contact reference fields.