[REF] Add strict types to Utils_Mail::Send #20171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function only returns a bool - this makes that explicit / forced and also removes handling for it to return a PEAR_Error in one place that calls it. A couple of unused params are removed
|
(Standard links)
|
|
Looks good to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Add strict types to Utils_Mail::Send
Before
Function onl returns a bool - but code that calls it handles the possibility of it returning a PEAR_Error, some unused variables
After
Function explicitly only returns a bool so the next person won't need to double check the function to be sure they can remove the PEAR error handling
Technical Details
Comments