[NFC] code cleanups in test class

[eileenmcnaughton]

Overview

[NFC] code cleanups in test class

• various best practice improvements

Before

After

• types declared (strictly)
• exceptions declared

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Test fails relate @eileenmcnaughton

[eileenmcnaughton]

@seamuslee001 yep - it turns out the tests were trying to lock in bad grammar (well I guess there is a chance it's just differently localised grammar but I think without the with is more correct)