[php8-compat][REF] Fix some more test failures in php8 #20516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -1360,7 +1360,7 @@ public function submit($params) { | |||
| } | |||
|
|
|||
| // also store lineitem stuff here | |||
| if ((($this->_lineItem & $this->_action & CRM_Core_Action::ADD) || | |||
| if ((($this->_lineItem && $this->_action & CRM_Core_Action::ADD) || | |||
There was a problem hiding this comment.
This makes me a little nervous as the impact might be to change behaviour - I agree it looks like a bug but sometimes fixing bad code breaks things - have we branched yet?
There was a problem hiding this comment.
I stepped through this in the code &
- $this->_lineItem is always set for paid events & unset for unpaid events and
- the behaviour is unchanged by this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the following test failures on php8
Undefined array key "survey_id"
Undefined array key "urlIsPublic"
TypeError: Unsupported operand types: array & int
Before
Those tests fail on php8
After
Those tests pass on php8
ping @eileenmcnaughton @totten @demeritcowboy