APIv4 - Fix output of membershipType auto_renew field #20840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
CRM_Member_Form_MembershipRenewalTest.testSubmitRecurCompleteInstantWithMail with data set #0 |
|
@colemanw Confirmed that the patch fixes the return value of auto_renew. Thanks for the fix :)
Test failures seem mostly like test related? the params are passed as boolean, instead of 0/1/2. |
The field had been declared a "boolean" in the schema, which at a SQL level is exactly the same as "tinyint" but it was resulting in incorrect API output.
colemanw
force-pushed
the
membershipTypeAutoRenewFix
branch
from
760a82a
to
0525019
Compare
|
@jitendrapurohit @eileenmcnaughton I've updated the tests. Want to merge-on-pass? |
|
unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure the "auto_renew" field is returned correctly by the MembershipType API.
Before
Returns true/false
After
Returns int
Technical Details
The field had been declared a "boolean" in the schema, which at a SQL level is exactly the same as "tinyint" but it was resulting in incorrect API output.
See #20768 (comment)