Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Add is_active extra field to Domain entity #22159

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 29, 2021

Overview

Adds a new calculated field to APIv4 making it easier to get the current active domain.

Before

You could use the magic keyword "current_domain" which is a holdover from APIv3.

After

The magic keyword still works but calculated fields are the way of the future for APIv4 so this new field is consistent with the new approach.

@civibot
Copy link

civibot bot commented Nov 29, 2021

(Standard links)

@civibot civibot bot added the master label Nov 29, 2021
@eileenmcnaughton
Copy link
Contributor

@colemanw do we use 'is_current' anywhere else in a non-time-centric way in apiv4?

@colemanw
Copy link
Member Author

@colemanw do we use 'is_current' anywhere else in a non-time-centric way in apiv4?

@eileenmcnaughton no, for other entities is_current has a temporal meaning. If it's confusing we could change this field name to something else. Not sure what.

@eileenmcnaughton
Copy link
Contributor

@colemanw yeah - I'm not sure - I'll see if anyone else has any thoughts

@colemanw colemanw marked this pull request as draft January 28, 2022 16:13
@colemanw colemanw changed the title APIv4 - Add is_current extra field to Domain entity APIv4 - Add is_active extra field to Domain entity Apr 9, 2022
@colemanw colemanw marked this pull request as ready for review April 9, 2022 00:34
@colemanw
Copy link
Member Author

colemanw commented Apr 9, 2022

@eileenmcnaughton based on your emoji poll I've renamed this to is_active.

@eileenmcnaughton eileenmcnaughton merged commit 3453488 into civicrm:master Apr 10, 2022
@eileenmcnaughton eileenmcnaughton deleted the isCurrentDomain branch April 10, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants