CiviGrant - Don't auto-create any grant types

[colemanw]

Port of #22905 for 5.48

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

The 5.47 PR has been merged. Merging this one.

[demeritcowboy]

Something got missed here - the sql file doesn't run without a corresponding task to runSQL. Since it's in beta1.mysql, it needs the corresponding php func. PR coming.

[colemanw]

@demeritcowboy are you sure about that? This function says it grabs upgrade steps directly from the mysql.tpl files:

civicrm-core/CRM/Upgrade/Form.php

Lines 314 to 331 in c09c9d3

	/**
	* Get a list of all patch-versions that appear in upgrade steps, whether
	* as *.mysql.tpl or as *.php.
	*
	* @return array
	* @throws Exception
	*/
	public function getRevisionSequence() {
	$revList = [];
	foreach (self::incrementalPhpObjectVersions() as $majorMinor) {
	$phpUpgrader = self::incrementalPhpObject($majorMinor);
	$revList = array_merge($revList, array_values($phpUpgrader->getRevisionSequence()));
	}
	usort($revList, 'version_compare');
	return $revList;
	}

And down here, for each upgrade step it will run the php upgrader if it exists OR just the sql file:

civicrm-core/CRM/Upgrade/Form.php

Lines 753 to 758 in c09c9d3

	if (is_callable([$versionObject, $phpFunctionName])) {
	$versionObject->$phpFunctionName($rev, $originalVer, $latestVer);
	}
	else {
	$upgrade->processSQL($rev);
	}

[demeritcowboy]

Something similar came up earlier too and I thought I had tracked it down to the upgrade steps not running. For this one, starting from 5.48.alpha1, if I run the upgrade, here are the steps that it logs. Maybe it's just a logging issue.

Mar 13 11:39:30  [info] Running task: Cleanup old files


Mar 13 11:39:30  [info] Running task: Checking extensions


Mar 13 11:39:30  [info] Running task: Begin Upgrade to 5.48.beta1


Mar 13 11:39:30  [info] Running task: Upgrade DB to 5.48.beta1


Mar 13 11:39:31  [info] Running task: Finish Upgrade DB to 5.48.beta1


Mar 13 11:39:31  [info] Running task: Begin Upgrade to 5.49.alpha1


Mar 13 11:39:31  [info] Running task: Upgrade DB to 5.49.alpha1


Mar 13 11:39:31  [info] Running task: Upgrade DB to 5.49.alpha1: SQL


Mar 13 11:39:32  [info] Running task: Finish Upgrade DB to 5.49.alpha1


Mar 13 11:39:32  [info] Running task: Finish core DB updates 5.49.alpha1