-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core#1836 - restrict scheduled reminder 'Also Include' to non-events #23101
Conversation
(Standard links)
|
Test error has affected many, but not all, test runs today - we can test this again in the hope of getting rid of the red x distraction Stacktrace |
test this please |
1 similar comment
test this please |
Note we do think that this PR could be merged. However it would be better to tackle the underlying problem and solve the issue of sending scheduled reminders for events which also have @eileenmcnaughton or @colemanw could one of you merge this PR? |
Thanks @jaapjansma - since this doesn't touch the php layer I agree no test is OK |
… Include" After reading civicrm#23445 and civicrm#23101, I wanted to see the test-coverage for "Also Include". There's a little... but not a lot. There was an interesting-but-inert test-case. Before ------ * Test-case is commented-out * Comments indicate a vague sense of confusion After ----- * Test-case is enabled * Comments indicate a well-developed, robust sense of confusion
… Include" After reading civicrm#23445 and civicrm#23101, I wanted to see the test-coverage for "Also Include". There's a little... but not a lot. There was an interesting-but-inert test-case. Before ------ * Test-case is commented-out * Comments indicate a vague sense of confusion After ----- * Test-case is enabled * Comments indicate a well-developed, robust sense of confusion
Overview
This is a rewrite of #20425. As @magnolia61 pointed out - it was a good idea, and I'm not sure why I closed the PR. It was probably accidental, because the issue is still a problem.
Before
In Scheduled Reminders, you can select "Also Include" recipients with event reminders, even though that's broken.
After
You can't select "Also Include" on event reminders. If you selected "Also Include" that choice is removed.
Comments
@magnolia61 you seemed to have an interest in this?
For testing purposes - it's best to bring up a site that has the patch and one that doesn't in adjoining tabs, and observe the difference in behavior when the same options are selected.