Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tags fields are assigned to tpl for email form test #23183

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Re-instate #22614

@demeritcowboy I looked at ^^ and you reported that it broke something - but I realised I couldn't replicate the thing you said was broken - you said "but running it this breaks tags for attachments (the field doesn't appear)." - - I can't figure out how to make the tag field appear for attachments....

@civibot
Copy link

civibot bot commented Apr 13, 2022

(Standard links)

@civibot civibot bot added the master label Apr 13, 2022
@demeritcowboy
Copy link
Contributor

On dmaster.demo right now: https://dmaster.demo.civicrm.org/civicrm/activity?reset=1&action=add&context=standalone

Expand attachments section.

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy OK - I think I figured it out - I added some additional cleanup

@demeritcowboy
Copy link
Contributor

jenkins retest this please

@demeritcowboy
Copy link
Contributor

demeritcowboy commented Apr 19, 2022

There's something wrong with how attachment tags get stored, but it doesn't seem to be from this PR.
https://lab.civicrm.org/dev/core/-/issues/3185

@demeritcowboy demeritcowboy merged commit 6449252 into civicrm:master Apr 19, 2022
@eileenmcnaughton eileenmcnaughton deleted the notice branch April 19, 2022 19:28
@eileenmcnaughton
Copy link
Contributor Author

Thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants