Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] Standardise import text for CustomData import #23219

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Standardise import text for CustomData import - also note there is a master-only regression on this page prior to this patch

Before

image

After

image

Technical Details

This Does alter the text a little - if it's not OK - it might make sense to move it to the php layer & assign the text

Comments

@civibot
Copy link

civibot bot commented Apr 15, 2022

(Standard links)

@civibot civibot bot added the master label Apr 15, 2022
@eileenmcnaughton eileenmcnaughton changed the title Standardise import text for CustomData import [REF] [Import] Standardise import text for CustomData import Apr 18, 2022
@colemanw colemanw merged commit f70b9eb into civicrm:master Apr 20, 2022
@colemanw colemanw deleted the import_cust branch April 20, 2022 15:05
@colemanw
Copy link
Member

It's fine. That whole screen sucks so let's not think too hard about the help text.

@eileenmcnaughton
Copy link
Contributor Author

Lol

@colemanw
Copy link
Member

@eileenmcnaughton looking at those screenshots... one way to make the scree suck less IMO would be to use a select2 instead of radio buttons for selecting a date format. That rather obscure setting is dominating the screen real-estate on the form, and select2 would make it much more compact.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw it's a lot less obscure when you live in NZ :-) - but yeah if I get to it I might try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants