dev/core#3709 - Make the activity search filter on manage case less unwieldy

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/3709

Before

On manage case, in the activities section, you can expand the search filters and one of the choices is activity type. The list can be unwieldy and often includes some irrelevant types.

After

Only lists the activity types for activities that have been filed on that case.

There's no point filtering to ones that aren't there. Someone might want to confirm to themself visually that there aren't any of a given type, but you can still do that by just looking at the dropdown choices.

Technical Details

Comments

Has test

The only other place I see activityForm() called from is one place in civihr, and it doesn't pass the second param.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks!