Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A library upgrade that should have no effect.
Before
net_smtp 1.9.2.
After
net_smtp 1.10.0
Comments
It's been a thorn in my side for the past 10 years or so that CiviCRM doesn't support STARTTLS on unauthenticated connections.
Some work has been done to fix this upstream, and
net_smtp
has a new version. They're only 4 commits apart, and the newstarttls()
function is the only change to code (other commits are documentation, CI change, and tagging a new release).This isn't enough by itself - we also need a new version of
pear/Mail
(once this commit is merged). But I'm submitting this because it's a small change that's easily reviewed.