Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor test cleanup #24071

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Minor test cleanup #24071

merged 1 commit into from
Aug 2, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Minor test cleanup

@civibot civibot bot added the master label Jul 28, 2022
@civibot
Copy link

civibot bot commented Jul 28, 2022

(Standard links)

*
* @var bool
*/
protected $isValidateFinancialsOnPostAssert = TRUE;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as parent now

@@ -788,7 +777,10 @@ public function testSubmitNonPrimaryEmail(): void {
protected function submitForm(int $eventID, array $params): void {
$_REQUEST['id'] = $eventID;
$form = $this->getFormObject('CRM_Event_Form_Registration_Confirm', []);
$form->set('params', [$params]);
if (!isset($params[0])) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More flexible

@demeritcowboy
Copy link
Contributor

The PR title might no longer be correct.

not ok 714 - Error: CRM_Contact_Page_View_UserDashBoardTest::testEventDashboard
not ok 853 - Error: CRM_Contribute_Form_Task_InvoiceTest::testInvoiceForLineItems
not ok 1004 - Error: CRM_Core_BAO_ActionScheduleTest::testEventTypeRegistrationDate
not ok 1414 - Error: CRM_Core_CopyTest::testEventCopy
not ok 1820 - Failure: CRM_Event_Form_Registration_ConfirmTest::testWaitlistRegistrationContactIdParam
  ---
  message: 'Failure in api call for PaymentProcessor create:  DB Error: already exists'
  severity: fail
  ...
  not ok 1821 - Error: CRM_Event_Form_Registration_ConfirmTest::testTaxMultipleParticipant
not ok 1822 - Error: CRM_Event_Form_Registration_ConfirmTest::testOnlineRegNoPrice
not ok 1823 - Error: CRM_Event_Form_Registration_ConfirmTest::testAssignProfiles
not ok 1824 - Failure: CRM_Event_Form_Registration_ConfirmTest::testNoteSubmission
  ---
  message: 'Failure in api call for UFGroup create:  DB Error: already exists'
  severity: fail
  ...
  not ok 1825 - Error: CRM_Event_Form_Registration_ConfirmTest::testSubmitNonPrimaryEmail
not ok 1826 - Error: CRM_Event_Form_Registration_RegisterTest::testMinValueForPriceSet

@eileenmcnaughton
Copy link
Contributor Author

ah yeah - I changed the return array in the end too - will fix....

@eileenmcnaughton
Copy link
Contributor Author

ah - permissions = FALSE

@demeritcowboy
Copy link
Contributor

All the same test fails except the first one.

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy - looks like I got there

@seamuslee001 seamuslee001 merged commit 437d148 into civicrm:master Aug 2, 2022
@seamuslee001 seamuslee001 deleted the conf branch August 2, 2022 01:17
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants