-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor test cleanup #24071
Minor test cleanup #24071
Conversation
(Standard links)
|
* | ||
* @var bool | ||
*/ | ||
protected $isValidateFinancialsOnPostAssert = TRUE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as parent now
@@ -788,7 +777,10 @@ public function testSubmitNonPrimaryEmail(): void { | |||
protected function submitForm(int $eventID, array $params): void { | |||
$_REQUEST['id'] = $eventID; | |||
$form = $this->getFormObject('CRM_Event_Form_Registration_Confirm', []); | |||
$form->set('params', [$params]); | |||
if (!isset($params[0])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More flexible
a69e9d4
to
1a8e2ae
Compare
The PR title might no longer be correct.
|
ah yeah - I changed the return array in the end too - will fix.... |
ah - permissions = FALSE |
All the same test fails except the first one. |
3ac742c
to
ed1250b
Compare
@demeritcowboy - looks like I got there |
thanks @seamuslee001 |
Minor test cleanup