dev/joomla#41 [REF] Amend Joomla Bootstrapping code and hook code to … #24796
Conversation
|
(Standard links)
|
| else { | ||
| require $joomlaBase . '/libraries/bootstrap.php'; | ||
| require_once $joomlaBase . '/includes/framework.php'; | ||
| } | ||
| self::getJVersion($joomlaBase); |
There was a problem hiding this comment.
@seamuslee001 can you move this function call to L577 above? That will prevent the internal notices :
Warning: Use of undefined constant JVERSION - assumed 'JVERSION' (this will throw an Error in a future version of PHP) in /Applications/MAMP/htdocs/joomla/administrator/components/com_civicrm/civicrm/CRM/Utils/System/Joomla.php on line 589
Deprecated: Bootstrapping Joomla using the /Applications/MAMP/htdocs/joomla4/libraries/import.legacy.php file is deprecated. Use /Applications/MAMP/htdocs/joomla4/libraries/bootstrap.php instead. in /Applications/MAMP/htdocs/joomla/libraries/import.legacy.php on line 16
Warning: Use of undefined constant JVERSION - assumed 'JVERSION' (this will throw an Error in a future version of PHP) in /Applications/MAMP/htdocs/joomla4/administrator/components/com_civicrm/civicrm/CRM/Utils/System/Joomla.php on line 593There was a problem hiding this comment.
@monishdeb good point updated that now
CRM/Utils/Hook/Joomla.php
Outdated
| @@ -74,7 +74,7 @@ public function invokeViaUF( | |||
| $app = JCli::getInstance(); | |||
| } | |||
| else { | |||
| $app = JApplicationCli::getInstance(); | |||
| $app = Joomla\CMS\Factory::getApplication(); | |||
There was a problem hiding this comment.
Umm not necessary but would be better to have a leading slash, i.e. \Joomla\CMS\Factory::getApplication();
There was a problem hiding this comment.
@monishdeb updated that now
|
@seamuslee001 thanks for the fix. The patch works for me, tested against Joomla 4 and 3. I have mentioned a few minor changes. |
seamuslee001
force-pushed
the
dev_joomla_41
branch
2 times, most recently
from
e14304d
to
f00bee2
Compare
|
@vingle can you please test this patch? |
monishdeb
added
the
merge ready
|
As per the latest comment here there is an issue with webcron. |
monishdeb
removed
the
merge ready
…get cron to work on Joomla 4
seamuslee001
force-pushed
the
dev_joomla_41
branch
from
f00bee2
to
c7f45e3
Compare
|
Have tested this with an http cron for J3 and J4 - works with both (calling the url returns the right error msgs with the wrong details, runs the job with the correct details). |
|
Merging based on @vingle and also Josh's testing in the gitlab |
…get cron to work on Joomla 4
Overview
This Alters the joomla bootstrapping process in CiviCRM when we need to bootstrap joomla after bootstrapping civi (e.g. cron.php and cv) to work with Joomla 4 and I think will work with Joomla 3
Before
Cron does not work on Joomla 4
After
Cron I believe works on Joomla 4
ping @monishdeb @vingle @joshgowans