Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dev/core#4060: Fix cv failure on J3. #25287

Closed
wants to merge 1 commit into from

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Jan 6, 2023

Overview

cv fails on J3 - see dev/core#4060

Before

Failed to start application error

After

No error

Technical Details

This code was changed by #24796 for J4 compatibility.

This PR simply reverts to the previous command for J3 leaving J4 as is.

@civibot
Copy link

civibot bot commented Jan 6, 2023

(Standard links)

@civibot civibot bot added the master label Jan 6, 2023
@demeritcowboy
Copy link
Contributor

Can you put against 5.58? It sounds like this broke in 5.56.

@demeritcowboy
Copy link
Contributor

@aydun Can you rebase? It would be good to get this into a point release.

@aydun aydun mentioned this pull request Jan 10, 2023
@aydun
Copy link
Contributor Author

aydun commented Jan 10, 2023

@demeritcowboy - see #25306

@totten
Copy link
Member

totten commented Jan 10, 2023

+1 for 5.58-rc variant.

Patch looks plausible from a distance. Any concerns @seamuslee001 @monishdeb?

@seamuslee001
Copy link
Contributor

This seems fine to me just needs to be on the 5.58 branch

@monishdeb
Copy link
Member

looks good to me too and yes it should be on 5.58-rc branch

@monishdeb
Copy link
Member

@seamuslee001 @totten I have submitted 5.58-rc PR #25320 on behalf of @aydun

@lcdservices
Copy link
Contributor

I think this should be included in a 5.57.x release (and maybe 5.56.x). A lot of people will be upgrading because of the security patches and find their cron breaks.

@aydun
Copy link
Contributor Author

aydun commented Jan 11, 2023

@seamuslee001 @totten I have submitted 5.58-rc PR #25320 on behalf of @aydun

Thanks @monishdeb

So we have:

Should cover most bases!

@demeritcowboy
Copy link
Contributor

5.57 now merged. This was magically upmerged into master already via 5b8696f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants