Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PriceSetTest - Fix test-run on case-insensitive filesystem #24892

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

totten
Copy link
Member

@totten totten commented Nov 3, 2022

Before

The test internally+arbitrarily inconsistent about PriceFieldValue vs pricefieldvalue.

On case-insensitive filesystem, this leads to a test failure:

$ CIVICRM_UF=UnitTests phpunit8 tests/phpunit/CRM/Price/BAO/
PHPUnit 8.5.27 #StandWithUkraine

.
Installing dmastertest_qmzfj database
...
Fatal error: Cannot redeclare civicrm_api3_price_field_value_create() (previously declared in /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/api/v3/PriceFieldValue.php:31) in /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/api/v3/Pricefieldvalue.php on line 31

After

The test internally consistent. Test passes.

@yashodha
Copy link
Contributor

yashodha commented Nov 3, 2022

test this please

@demeritcowboy
Copy link
Contributor

The test passed before on windows for me but the patch is obviously correct so 🤷

@demeritcowboy demeritcowboy merged commit 0ad4920 into civicrm:master Nov 3, 2022
@totten totten deleted the master-pst branch November 3, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants