Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'cannot determine default entity' error on New Batch page #25189

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

MegaphoneJon
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/core/-/issues/4036

"New Batch" no longer loads. When you try, you get an error.

Before

image

After

No error.

Technical Details

The error describes things pretty well.

@civibot
Copy link

civibot bot commented Dec 16, 2022

(Standard links)

@civibot civibot bot added the master label Dec 16, 2022
@MegaphoneJon MegaphoneJon changed the base branch from master to 5.57 December 16, 2022 15:05
@civibot civibot bot added 5.57 and removed master labels Dec 16, 2022
@demeritcowboy
Copy link
Contributor

Thanks - can you put against 5.57?

@demeritcowboy
Copy link
Contributor

Ah you just did.

@MegaphoneJon
Copy link
Contributor Author

@demeritcowboy This pulls in a bunch of additional commits though. I feel like there's a way for this to not happen, but not sure what it is? I just tried creating a new branch off of 5.57 and cherry-picked my commit, but when I force-push to this branch it says "Everything up-to-date".

@demeritcowboy
Copy link
Contributor

demeritcowboy commented Dec 16, 2022

Since the actual change is so small, I would do git fetch origin 5.57; git reset --hard origin/5.57 and then manually reapply the change, commit, and force-push.

@MegaphoneJon
Copy link
Contributor Author

Thanks @demeritcowboy, done.

@demeritcowboy demeritcowboy merged commit 785d5f8 into civicrm:5.57 Dec 16, 2022
@demeritcowboy demeritcowboy mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants