dev/core#4213 Make frontend_title required

[eileenmcnaughton]

Overview

dev/core#4213 Make frontend_title required

Before

Front end title may be missing as we never populated it

After

Front end title updated to the title value if not populated

Technical Details

This picks up on the proposal here - https://lab.civicrm.org/dev/core/-/issues/4213

On looking into the 3 entities ...

1. ContributionPage

• does not have a unique name field
• title is required at the Form layer but not the DB layer
• I have made front end title required at the form layer but not the db

2. Group

• does have a name field not required at DB layer
• title is required at the form layer but not the db layer
• I have made front end title required at the form layer but not the db

3. Profile (UF Group)

• does have a name field not required at DB layer - have a unique key
• title is NOT required at the form or db layer
• I have made front end title also optional....

Comments

@jusfreeman @colemanw @seamuslee001 @demeritcowboy - I originally thought it would be good to hit the same release as the payment processor frontend_title (which this does) - but am having some doubts as I'm just processing the variations above.

I guess the question is whether a one-off update and make the frontend_title 'as required as' title is an OK amount of change for one hit or whether it could just perpetuate the issues.

In terms of usage - I haven't tracked down all the usages - but the group is often used in message templates - which can be updated to the {group.frontend_title} off the back of this I think.

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Not quite sure why - the other fail is an e-notice in ContributionBase which should be an easy enough fix

Cannot execute UPDATE civicrm_contribution_page
SET frontend_title_en_US = title_en_US WHERE frontend_title_en_US IS NULL OR frontend_title_en_US = '', frontend_title_af_ZA = title_af_ZA WHERE frontend_title_af_ZA IS NULL OR frontend_title_af_ZA = '', frontend_title_bg_BG = title_bg_BG WHERE frontend_title_bg_BG IS NULL OR frontend_title_bg_BG = '': DB Error: syntax error

---- LOG OUTPUT: ----

[aydun]

Given that we're moving forward with replacing old forms with FormBuilder/API4, it seems rather incomplete to be making changes now to require things at a form level without corresponding changes in FormBuilder/API4. Or maybe they have been considered and not thought necessary, but a note explaining why would be useful.

[eileenmcnaughton]

Yeah - that probably is an argument for making required at the db level

[eileenmcnaughton]

This was too hard - trying to do just one of the fields #26259

[eileenmcnaughton]

I've recovered enough to start on group #26546