-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#4213 Make contribution_page.frontend_title required #26259
dev/core#4213 Make contribution_page.frontend_title required #26259
Conversation
No issue was found matching the number given in the pull request title. Please check the issue number. |
(Standard links)
|
If we're doing this, maybe we should rename Title (the non-public one), to Name or Page Name, so it's more clear, because it isn't really the title of the page anymore, since it doesn't appear on the page. That's maybe not ideal with the new name field, but I think it would be more clear to users. |
@larssandergreen good idea - note the name field won't be exposed to users - it's just to have a machine name like other entities |
@eileenmcnaughton Yes, just confusing for us, but that's bearable. |
0198e47
to
215d56a
Compare
a5d1424
to
b322a8a
Compare
b075d62
to
75c5b6b
Compare
@colemanw @seamuslee001 down to 1 fail
|
You could do a loop like this: civicrm-core/CRM/Case/xml/configuration.sample/case_sample.mysql.tpl Lines 34 to 42 in d077a5f
|
75c5b6b
to
da84233
Compare
da84233
to
a10eb98
Compare
@seamuslee001 @colemanw it passed!!!! |
@@ -14,3 +14,19 @@ VALUES | |||
( {$domainID}, 'https://civicrm.org/help?src=iam', '{ts escape="sql" skip="true"}Get Help{/ts}', 'Get Help', NULL, 'AND', @adminHelplastID, '1', NULL, 2 ); | |||
|
|||
UPDATE IGNORE `civicrm_navigation` SET `name` = 'Register Your Site', `label` = '{ts escape="sql" skip="true"}Register Your Site{/ts}' WHERE `name` = 'Register your site'; | |||
|
|||
-- Ensure new name field is not null/unique. Setting to ID is a bit lazy - but sql localisation is painful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eileenmcnaughton - is this an outdated comment? You seem to have pushed through the pain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no - that update is still just setting name to id
Overview
dev/core#4213 Make frontend_title required
Before
frontend_title field optional - leading to inconsistency
After
frontend_title field now required - also I added a unique name field
Technical Details
#25993 was a bit too tricky so this tackles just one of the 3 entities
Comments