dev/core#4213 Make contribution_page.frontend_title required

[eileenmcnaughton]

Overview

dev/core#4213 Make frontend_title required

Before

frontend_title field optional - leading to inconsistency

After

frontend_title field now required - also I added a unique name field

Technical Details

#25993 was a bit too tricky so this tackles just one of the 3 entities

Comments

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[larssandergreen]

If we're doing this, maybe we should rename Title (the non-public one), to Name or Page Name, so it's more clear, because it isn't really the title of the page anymore, since it doesn't appear on the page. That's maybe not ideal with the new name field, but I think it would be more clear to users.

[eileenmcnaughton]

@larssandergreen good idea - note the name field won't be exposed to users - it's just to have a machine name like other entities

[larssandergreen]

@eileenmcnaughton Yes, just confusing for us, but that's bearable.

[eileenmcnaughton]

@colemanw @seamuslee001 down to 1 fail

• not quite sure if there is a way to rewrite that bit with the exosting localize function

Cannot execute UPDATE `civicrm_contribution_page`
SET `frontend_title_en_US` = `title_en_US`
  WHERE `frontend_title_en_US` IS NULL OR `frontend_title_en_US` = '';, UPDATE `civicrm_contribution_page`
SET `frontend_title_af_ZA` = `title_af_ZA`
  WHERE `frontend_title_af_ZA` IS NULL OR `frontend_title_af_ZA` = '';, UPDATE `civicrm_contribution_page`
SET `frontend_title_bg_BG` = `title_bg_BG`
  WHERE `frontend_title_bg_BG` IS NULL OR `frontend_title_bg_BG` = '': DB Error: syntax error

[colemanw]

You could do a loop like this:

civicrm-core/CRM/Case/xml/configuration.sample/case_sample.mysql.tpl

Lines 34 to 42 in d077a5f

	{if $multilingual}
	{foreach from=$locales item=locale}
	UPDATE civicrm_option_value SET name = 'Open' where option_group_id = @csgId AND label_{$locale} = 'Ongoing';
	UPDATE civicrm_option_value SET name = 'Closed' where option_group_id = @csgId AND label_{$locale} = 'Resolved';
	{/foreach}
	{else}
	UPDATE civicrm_option_value SET name = 'Open' where option_group_id = @csgId AND label = 'Ongoing';
	UPDATE civicrm_option_value SET name = 'Closed' where option_group_id = @csgId AND label = 'Resolved';
	{/if}

[eileenmcnaughton]

@seamuslee001 @colemanw it passed!!!!

[colemanw]

@eileenmcnaughton - is this an outdated comment? You seem to have pushed through the pain.

[eileenmcnaughton]

no - that update is still just setting name to id