Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to ensure we are excluding quick config price sets as per t… #27083

Merged
merged 1 commit into from Aug 17, 2023

Conversation

seamuslee001
Copy link
Contributor

…he previous function

Overview

This is a follow up to #27079 as per the old code it was setting $isQUickConfig to be 1 which meant that the SQL excluded is quick config price sets https://github.com/civicrm/civicrm-core/blob/master/CRM/Price/BAO/PriceSet.php#L273

@eileenmcnaughton

@civibot
Copy link

civibot bot commented Aug 17, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the 5.65 label Aug 17, 2023
@seamuslee001 seamuslee001 merged commit fc2977c into civicrm:5.65 Aug 17, 2023
3 checks passed
@seamuslee001 seamuslee001 deleted the followup_price_set_extends branch August 17, 2023 22:29
seamuslee001 added a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants