Use APIv4 to check if a PriceSet extends CiviMember (lab.civicrm issue 4486) #27079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷 Introduction for new contributors
Quick links for reviewers |
brienneK
changed the title
brienneK
changed the title
| ->addJoin('PriceSet AS price_set', 'LEFT', ['price_set_id', '=', 'price_set.id']) | ||
| ->addWhere('entity_table', '=', 'civicrm_contribution_page') | ||
| ->addWhere('entity_id', '=', $contributionPageId) | ||
| ->addWhere('price_set.extends:name', 'CONTAINS', 'CiviMember') |
There was a problem hiding this comment.
@briennekordis can you add in addWhere('price_set.is_quick_config', '=', 0) to match the original function https://github.com/civicrm/civicrm-core/blob/master/CRM/Price/BAO/PriceSet.php#L273
seamuslee001
added a commit
to seamuslee001/civicrm-core
that referenced
this pull request
Aug 16, 2023
…this time on the Amounts tab of the contribution page config
seamuslee001
added a commit
to seamuslee001/civicrm-core
that referenced
this pull request
Aug 16, 2023
…this time on the Amounts tab of the contribution page config
|
I'm going to merge this and do a follow up PR |
eileenmcnaughton
added a commit
that referenced
this pull request
Aug 17, 2023
[REF] Fix poor checking of extends field as per PR #27079 but this ti…
seamuslee001
added a commit
to seamuslee001/civicrm-core
that referenced
this pull request
Aug 17, 2023
…this time on the Amounts tab of the contribution page config
pradpnayak
reviewed
Aug 22, 2023
| ->addWhere('price_set.extends:name', 'CONTAINS', 'CiviMember') | ||
| ->execute() | ||
| ->first(); | ||
| if (!$priceSetExtendsMembership) { |
There was a problem hiding this comment.
This will be always empty when creating a new one.
|
@briennekordis Thanks for doing this with the API, sorry I wasn't able to come back and review before it got merged. I've fixed the regression @pradpnayak found in #27120. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
(This is a new PR derived from #27076 to be made against 5.65)
This patch resolves the issue reported on lab.civicrm regarding the inability to change membership price set on contribution pages/
Before
A user cannot switch the options for the Membership Price Set field, and instead get the follow error, despite that the Amounts tab is configured correctly:
After
A user should be able to switch the options for the Membership Price Set without error.