Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont crash if we can't start a session when a file path doesnt exist #29363

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Feb 10, 2024

Before

CRM_Core_Config_MagicMerge tries to put warnings about file path issues into the session.

If a situation arises where the warnings are the root cause of not being able to init the session, the system crashes. Users get an error about not being able to start the session (but no immediate indication this is because of the file path issues).

After

If there's an error with putting the warnings into the session, we print them to the screen and then continue.

The user gets the warning, which is more useful to them. They may get subsequent warnings.

Technical details

Potentially this would be good behaviour generally, and could live in CRM_Core_Session::setStatus - but felt a bit safer to restrict to these specific warnings (which have a specific relevant example with Standalone).

Comments

For an example:

On a Standalone install, remove your custom extensions directory and make its parent directory unwriteable so the server can't recreate it ( e.g. mv web/upload/ext web/upload/ext.moved && chmod a-w web/upload). You get a crash about not having the Standalone SessionHandler (because the Standaloneusers extension that manages sessions can't be initialised, in turn because the Extension system can't boot up, because the config loading crashes at this point).

Copy link

civibot bot commented Feb 10, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 10, 2024
@ufundo ufundo marked this pull request as ready for review February 11, 2024 20:06
@artfulrobot
Copy link
Contributor

tested, works as described. MErging thanks @ufundo

@artfulrobot artfulrobot merged commit 10d6dbf into civicrm:master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants