Pass values into DedupeRule->sql() rather than hybrid object

[eileenmcnaughton]

Overview

Pass values into DedupeRule->sql() rather than hybrid object

Before

Most of the properties accessed from sql() are straight from the db find but it also passes a couple of other properties by setting them on the class

After

This fixes so the values the function needs are clearly passed in

Technical Details

It doesn't really make sense for this query calculation function to be on a different class I kinda get what they were thinking but the way our BAOs are half a collection of static functions but occassionally get serious about being an object but then like extra properties set without explanation does us no favours. In this case it would be most sane if all the query calculation was on the same class (probably a new one but for now just looking at one of the existing ones). To do that we need to get clearer about the input the sql() function needs - this switches it most of the way to being static-ready & move-ready by passing in the values as arrays rather than setting them as properties

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗