Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-18445 don't 'Assign Case Role' to client #8186

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

kenwest
Copy link
Contributor

@kenwest kenwest commented Apr 20, 2016

This PR removes an unnecessary test that Case Id is set. Observing how the function is called, the Case Id will always be set, so the condition is always true and the else part is never executed.

Even if Case Id was not set, this test is not the appropriate response.


@colemanw
Copy link
Member

Jenkins, retest this please.

@colemanw
Copy link
Member

colemanw commented Apr 20, 2016

I've reviewed the code in question and agree that this is the proper fix. There is no need to check isset for a property that is always set. I haven't user-tested this myself but I trust Ken's assessment. Chances of regressions are low because the patch is limited to the 1 form exhibiting the bug.

@colemanw colemanw merged commit c269b52 into civicrm:master Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants