Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19507 Upgrade sql to repair bookkeeping trxns missing eft's #9265

Closed
wants to merge 1 commit into from

Conversation

JoeMurray
Copy link
Contributor

@JoeMurray JoeMurray commented Oct 14, 2016

Copy link
Contributor Author

@JoeMurray JoeMurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not ready...this isn't quite correct yet

@JoeMurray
Copy link
Contributor Author

Issues:

  1. there seem to be more ft's than just those created when changing payment instruments that are not linked to financial items even though they have no from financial_account. We need to create a new issue for that
  2. The query needs to insert eft's for more than one financial trxn per contribution, but refactoring join to ft's needing fi's outside of a group by that collapses all records for a contribution.
  3. The amounts for each linked financial item need more thought. While the most recent ft with links to fi's are a good way to find the current fi's after additions and deletions of line items, the amounts on the link may vary depending on it the ft was a partial payment or a complete payment etc.

@JoeMurray
Copy link
Contributor Author

redone elsewhere

@JoeMurray JoeMurray closed this Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants