CRM-19273 Fix in the usage of insertedLines and added test #9621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@civicrm-builder add to whitelist. |
|
Code review only: I like the code on skimming it, especially the test. The changes at https://github.com/civicrm/civicrm-core/pull/9621/files#diff-d05dcb57339ac128d06193a57b9ca1bcR1908 and https://github.com/civicrm/civicrm-core/pull/9621/files#diff-d05dcb57339ac128d06193a57b9ca1bcR2033 smell very good. If this passes some QA testing we should merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix solves the problem that I describe in my test scenario.
The base problem. When a line item is deselected it is set to zero. When it is selected again, there is no need toe create the line item (so in the code it is removed from the $insertLines). But the transactions details must be created as well, and that was skipped.
I added a test.