CRM-20154 dedupe code improvement, remove unused autoflip parameter #9873
Conversation
eileenmcnaughton
commented
Feb 22, 2017
•
eileenmcnaughton
commented
- CRM-20154: dedupe code improvement, remove unused autoflip parameter
eileenmcnaughton
force-pushed
the
dedupe_code
branch
from
c4bd319
to
d238756
Compare
|
test this please |
|
@JKingsnorth if you get a chance to look at this - its just a tidy up following that work we did on flipping in the prev_next table earlier - the $autoFlip parameter is not used so I wanted to get it out |
|
Sure I'll take a look asap, today or tomorrow I hope |
| @@ -281,7 +281,7 @@ public static function &valuesByID($id, $flip = FALSE, $grouping = FALSE, $local | |||
| * | |||
| * @param bool $flip | |||
| */ | |||
| public static function lookupValues(&$params, &$names, $flip = FALSE) { | |||
| public static function lookupValues(&$params, $names, $flip = FALSE) { | |||
There was a problem hiding this comment.
In comments just above it still refers to this as a 'reference array' of names. But looks like a good improvement since the names never get modified.
|
Pushed up a new PR with these changes (extending your commits here): #9893 |
|
I'm going to merge this now because these changes are agreed. I also agree with your extension to the changes, except there is one place missed, which I commented on your PR. I'll try to co-ordinate with you next week to get that last extra piece in and your additional changes merged. |
CRM-20154 dedupe code improvement, remove unused autoflip parameter
