Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NA functionality for multilabel classification problems #25

Merged
merged 4 commits into from
Jan 30, 2017

Conversation

samcarlos
Copy link
Contributor

No description provided.

assert "Input contains NaN, infinity or a value too large for \
dtype('float64')." in str(excinfo.value)

assert "Input contains NaN, infinity or a value too large for " \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the backslash here. Wasn't this test failure related to the fact that muffnn raises an AssertionError and not a ValueError? I might have misread circle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good this, as discussed.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samcarlos samcarlos merged commit 0c9992d into master Jan 30, 2017
@samcarlos samcarlos deleted the muffnn_na branch January 30, 2017 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants