ENH add monitor keyword to the autoencoder #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samcarlos This one is good to go. |
samcarlos
reviewed
Aug 28, 2017
| @@ -516,13 +516,22 @@ def _build_sigmoid_and_softmax_indices(self): | |||
| raise ValueError("Sigmoid indices and softmax indices cannot" | |||
| " overlap!") | |||
|
|
|||
| def partial_fit(self, X, y=None): | |||
| def partial_fit(self, X, y=None, monitor=None, **kwargs): | |||
There was a problem hiding this comment.
Why do you pass kwargs here? Is there anything in partial_fit that takes that as an input?
There was a problem hiding this comment.
Thus is part of the sklearn API. See here http://scikit-learn.org/stable/modules/generated/sklearn.base.TransformerMixin.html#sklearn.base.TransformerMixin.fit_transform
|
@samcarlos This is fixed! Back to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the monitor keyword to the autoencoder.
Closes #20