BUG update requirements to properly match python 2 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheilman
reviewed
Sep 12, 2017
There was a problem hiding this comment.
Why not just have the < 3.0 part?
Also, is there documentation somewhere about putting and in there like this? I couldn't find it easily.
(Relatedly, does it say anywhere that we require >= 2.7? It might be nice to add to the readme and make it so that info shows up on pypi, but that seems like a separate PR.)
|
See this https://www.python.org/dev/peps/pep-0496/#examples. The Happy to just have We don't require 2.7, but I doubt things work on older versions. |
|
Thanks for the pep link. I mainly suggested the change because I couldn't easily verify that the syntax was correct. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the requirements file to properly match python 2.7.
See here https://www.python.org/dev/peps/pep-0496/#examples