Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH add xavier init to MLP #68

Merged
merged 7 commits into from
Dec 1, 2017
Merged

ENH add xavier init to MLP #68

merged 7 commits into from
Dec 1, 2017

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Dec 1, 2017 •
edited
Loading

This PR moves the MLP to an xavier init.

Closes #64

@beckermr
Copy link
Contributor Author

beckermr commented Dec 1, 2017 •
edited
Loading

@gdj0nes for viz - thanks for the push to get this done! :)

mheilman
mheilman reviewed Dec 1, 2017
View reviewed changes
Copy link
Contributor

@mheilman mheilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note in the changelog? We should put that under "2.0.0 [unreleased]" or something like that since this is a breaking change.

@beckermr
Copy link
Contributor Author

beckermr commented Dec 1, 2017

Good catch! Back to you @mheilman!

mheilman
mheilman approved these changes Dec 1, 2017
View reviewed changes
Copy link
Contributor

@mheilman mheilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@beckermr beckermr merged commit 5d91ff6 into master Dec 1, 2017
@beckermr beckermr deleted the xavier-init branch December 1, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheilman mheilman mheilman approved these changes

Assignees

@mheilman mheilman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beckermr @mheilman