-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Update Version Notification #247
Conversation
cmd/root.go
Outdated
@@ -112,6 +112,10 @@ var completionZshCmd = &cobra.Command{ | |||
}, | |||
} | |||
|
|||
func checkLatestReleaseTimestamp() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
utility/color_util.go
Outdated
@@ -45,6 +49,21 @@ func Red(value string) string { | |||
|
|||
// Error is the function to handler all error in the Cli | |||
func Error(msg string, args ...interface{}) { | |||
githubTag := &latest.GithubTag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are no cyclic imports, can we replace this bit with common.VersionCheck ? ˀ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have replaced it
We should update a doc somewhere, either the Readme.md or something inside the docs/ folder indicating the new functionality. |
Sure @DMajrekar . I'll create a Readme regarding the same. |
1a47667
to
5221a79
Compare
5221a79
to
68d8816
Compare
Added notification to update the CLI version in error logs & added the daily reminder for CLI Version update.