CLI Update Version Notification #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/root.go
Outdated
| @@ -112,6 +112,10 @@ var completionZshCmd = &cobra.Command{ | |||
| }, | |||
| } | |||
|
|
|||
| func checkLatestReleaseTimestamp() { | |||
utility/color_util.go
Outdated
| @@ -45,6 +49,21 @@ func Red(value string) string { | |||
|
|
|||
| // Error is the function to handler all error in the Cli | |||
| func Error(msg string, args ...interface{}) { | |||
| githubTag := &latest.GithubTag{ | |||
There was a problem hiding this comment.
If there are no cyclic imports, can we replace this bit with common.VersionCheck ? ˀ
There was a problem hiding this comment.
Yes, I have replaced it
|
We should update a doc somewhere, either the Readme.md or something inside the docs/ folder indicating the new functionality. |
Sure @DMajrekar . I'll create a Readme regarding the same. |
satakshigarg
force-pushed
the
CLI_Update_Version
branch
from
1a47667
to
5221a79
Compare
satakshigarg
force-pushed
the
CLI_Update_Version
branch
from
5221a79
to
68d8816
Compare
RealHarshThakur
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notification to update the CLI version in error logs & added the daily reminder for CLI Version update.