Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning partial() doesn't work with rbart objects (yet) #35

Open
jbyoder opened this issue Feb 26, 2023 · 2 comments
Open

add warning partial() doesn't work with rbart objects (yet) #35

jbyoder opened this issue Feb 26, 2023 · 2 comments

Comments

@jbyoder
Copy link

jbyoder commented Feb 26, 2023

Running partial() on a model of class rbart fails, with error message

Error in pdbart(model, xind = x.vars, levs = lev, pl = FALSE) :
x.train must be a matrix, data.frame, formula, fitted bart model, or dbartsSampler

Can confirm that pdbart() doesn't recognize an rbart object as a fitted BART model; and the documentation for rbart_vi doesn't mention partials, so this is on some level a dbarts thing.

@cjcarlson
Copy link
Owner

I can't remember if pdbart() has never worked for rbart() but I think it used to - @vdorie am I imagining this? If not, it would be great functionality to add (and I'm working on fixing some other issues)

@cjcarlson
Copy link
Owner

Looks like this was never available functionality, because the partials in my plague WNA paper are all from the models before adding the random intercepts (it's the same model trained with and without RI's, no other differences). I'd just do that in your use case, but in the long run, I should probably add a warning to partial() unless Vince adds this feature!

@cjcarlson cjcarlson changed the title partial() fails with rbart object add warning partial() doesn't work with rbart objects (yet) Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants