Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux wheel support in github workflow #188

Closed
naetherm opened this issue Sep 26, 2022 · 6 comments · May be fixed by #190
Closed

Linux wheel support in github workflow #188

naetherm opened this issue Sep 26, 2022 · 6 comments · May be fixed by #190

Comments

@naetherm
Copy link

Hello,
I am wondering if there are plans on adding linux support in the provided wheel.yml file?
Maybe this is related to @yxliu-ntu who initially added the github actions support.

Are there also plans in automatically pushing created wheels to PyPi?

@Sinacam
Copy link
Contributor

Sinacam commented Sep 28, 2022

Hello, I am wondering if there are plans on adding linux support in the provided wheel.yml file?

We're apprehensive of adding Linux binaries due to the multitudes of Linux distros and our lack of testing on them.
May I ask if there are particular difficulties in installing a source distribution?
We will include MacOS binaries in upcoming releases.

Are there also plans in automatically pushing created wheels to PyPi?

If you're asking about nightly builds, we currently only plan to push wheels on version updates.
If you're asking about continuous deployment, our (internal) tests are somewhat finicky and we aren't currently automating that.

@betaboon
Copy link
Contributor

@Sinacam we're using libsvm-official in our ci-pipelines to build container-images et al.
if wheels for linux would be available that would drastically improve our buildtimes (and save costs and energy obviously)

for now we are storing linux-wheels on our own package-registry, but it would be preferable to have them available on pypi.

#190 already has all the ci-changes required to do proper matrix-build targetting windows+linux+macos.

looking forward to hearing fro myou.

@Sinacam
Copy link
Contributor

Sinacam commented Oct 11, 2022

Sorry for the late reply.
We have an private repo for development and have already accepted the ci-changes for MacOS, but they won't be available until the next release.
Unfortunately, since we currently can't guarantee the correctness of Linux binaries, we won't be providing them.

@betaboon
Copy link
Contributor

@Sinacam what would you need to feel like you can guarantee the correctness? what's the path forward here?

@betaboon
Copy link
Contributor

@Sinacam any update on this?

@Sinacam
Copy link
Contributor

Sinacam commented Aug 17, 2023

@betaboon I'm sorry for the large delay, I thought I got back to you already and completely forgot that I didn't.

@Sinacam what would you need to feel like you can guarantee the correctness? what's the path forward here?

Our tests have large manual elements in them and performing tests on different platforms are tedious. In an ideal world, we will have complete automated test suites with perfect accuracy, but we're a school research team so this type of engineering effort is hard to justify and hard to maintain long term as members come and go. So unfortunately, no plans to provide Linux binaries.

@cjlin1 cjlin1 closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants