Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build cache for PR builds #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build cache for PR builds #36

wants to merge 2 commits into from

Conversation

cjolowicz
Copy link
Owner

@cjolowicz cjolowicz commented Sep 20, 2019 •
edited
Loading

Closes #18

@cjolowicz
Use the same cache image for PR and branch builds
cc149cd 
- Pull branch image into Docker cache for PR builds

- Do not overwrite master cache image from PR builds

For PR builds, use the branch from which the PR originated, not the
target branch. This means that the same image is used for the Docker
build cache as for the corresponding branch build.

In Travis CI, the source branch is indicated by the
TRAVIS_PULL_REQUEST_BRANCH environment variable.
@cjolowicz
Update CHANGELOG.md
22d83cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not overwrite master cache image from PR builds
1 participant
@cjolowicz