Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error line/column returned by DeprecationsHaveAReason is not exact #13

Closed
cjoudrey opened this issue Aug 5, 2017 · 0 comments
Closed
Labels

Comments

@cjoudrey
Copy link
Owner

cjoudrey commented Aug 5, 2017

At the moment the DeprecationsHaveAReason rule will use the line and column of the FieldDefinition node rather than the affected @directive node.

This means if someone were to highlight the error it would lead to highlighting the wrong part of the line.

Example

Current:

11:3 The field `user.firstName` is deprecated but has no deprecation reason.

  firstName: String @deprecated
  ^^^^^^^^^

What we actually want:

11:21 The field `user.firstName` is deprecated but has no deprecation reason.

  firstName: String @deprecated
                    ^^^^^^^^^^^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant