Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for outdated Python versions #82

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

qarkai
Copy link
Contributor

@qarkai qarkai commented Jun 8, 2023

Also fix couple ruff warnings.

@cjrh
Copy link
Owner

cjrh commented Jun 25, 2023

Sorry for not commenting yet - I did see this PR, I just haven't had a good opportunity to look at it yet. I will get to it eventually promise 👍🏼

@cjrh
Copy link
Owner

cjrh commented Jun 25, 2023

After applying your changes, is the code still compatible with the versions in the pyproject.toml?

@qarkai
Copy link
Contributor Author

qarkai commented Jun 25, 2023

This PR removes quirks for Python <= 3.6.

Copy link
Owner

@cjrh cjrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you so much 🙏🏼

@cjrh cjrh merged commit 8249af2 into cjrh:master Jul 5, 2023
@qarkai qarkai deleted the py37 branch August 12, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants