[#1764] Reorder the creation of the SOLR cache of the validated package_... #1765
Conversation
…ge_dict so that it does not include the unvalidated package_dict.
|
@davidread this looks clearly correct, but could we have a regression test to make sure this stays fixed? |
|
I guess the reason you didn't write tests for this feature is because it is switched on with config |
|
When #1664 gets merged there will be a way to change config in tests: https://github.com/ckan/ckan/pull/1664/files#diff-5a91024560ddfe8fe0acb0d0ee83f738R144 (cherry picked commit from @vitorbaptista ) |
|
Oh, that doesn't matter in this case, though -- this config setting defaults to True. The reason I didn't write tests for this feature is probably just because I'm a terrible developer. Or maybe because the person reviewing my PR didn't insist on it. |
|
ah great, will have a stab - can't be too difficult for this one-liner... |
|
Hopefully these tests suit |
|
travis is ok now, so ready to review test |
Conflicts: ckan/new_tests/helpers.py
Conflicts: ckan/new_tests/helpers.py
...dict so that it does not include the unvalidated package_dict.
This relates to:
https://github.com/ckan/ckan/pull/1078/files
by @wardi