Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datapusher incompatible with Werkzeug 2.1.0 #247

Closed
sischall opened this issue Mar 31, 2022 · 2 comments
Closed

Datapusher incompatible with Werkzeug 2.1.0 #247

sischall opened this issue Mar 31, 2022 · 2 comments

Comments

@sischall
Copy link

sischall commented Mar 31, 2022

Since the new release of Werkzeug 2.1.0, the datapusher does not work anymore. In the log of the datapusher, you can see the following error:
ImportError: cannot import name 'safe_str_cmp' from 'werkzeug.security' (/usr/lib/python3.8/site-packages/werkzeug/security.py)
Looking in the release notes of werkzeug 2.1.0, https://werkzeug.palletsprojects.com/en/2.1.x/changes/, we can see, that the function 'safe_str_cmp' was removed.
A quick way to fix this, is to continue using version 2.0.x of werkzeug. This e.g. given can be done by uninstalling Werkzeug 2.1.0 and manually installing Werkzeug 2.0.x.

I start the datapusher in version 0.0.17 with docker as follows: https://github.com/okfn/docker-ckan/blob/master/datapusher/Dockerfile

Reproduce this issue:

@tomeksabala
Copy link

Today I've also encountered the issue. Our tmp fix was to patch the requirements.txt with:

# newer versions of Werkzeug not compatilbe with ckanserviceprovider
Werkzeug~=2.0.0

@amercader
Copy link
Member

The latest Datapusher version (0.0.18) should address that, can you check if it works for you @tomeksabala @sischall ? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants