Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization about Model Pattern #355

Open
Keith-CY opened this issue Jul 6, 2023 · 0 comments
Open

Optimization about Model Pattern #355

Keith-CY opened this issue Jul 6, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jul 6, 2023

After the demonstration of Kuai MVP, we got 2 feedback about Model Pattern at

@ActorProvider({ ref: { name: 'omnilock', path: `/:args/` } })
@LockPattern()
@DataPattern('0x')
@Omnilock()

  1. LockPattern is a newborn word in Kuai, the term Filter would be more acquainted in functional programming context. So what if renaming them into LockFilter, etc.

  2. LockPattern should work with another decorator, e.g.

    @LockPattern()
    @DataPattern('0x')
    @Omnilock()
    
    @LockPattern()
    @TypePattern()
    @Lock()
    

    what if achieve the function with a single decorator like

    @LockPattern('Omnilock')
    
    @LockPattern({ codeHash, hashType })
    
@Keith-CY Keith-CY added the documentation Improvements or additions to documentation label Jul 6, 2023
@Keith-CY Keith-CY self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 🏗 In progress
Development

No branches or pull requests

1 participant